Missing validation results in undefined behavior in `SparseTensorDenseAdd

Description

Impact

The implementation of tf.raw_ops.SparseTensorDenseAdd does not fully validate the input arguments:

import tensorflow as tf

a_indices = tf.constant(0, shape=[17, 2], dtype=tf.int64)
a_values = tf.constant([], shape=[0], dtype=tf.float32)
a_shape = tf.constant([6, 12], shape=[2], dtype=tf.int64)

b = tf.constant(-0.223668531, shape=[6, 12], dtype=tf.float32)

tf.raw_ops.SparseTensorDenseAdd(
    a_indices=a_indices, a_values=a_values, a_shape=a_shape, b=b)

In this case, a reference gets bound to a nullptr during kernel execution. This is UB.

Patches

We have patched the issue in GitHub commit 11ced8467eccad9c7cb94867708be8fa5c66c730.

The fix will be included in TensorFlow 2.9.0. We will also cherrypick this commit on TensorFlow 2.8.1, TensorFlow 2.7.2, and TensorFlow 2.6.4, as these are also affected and still in supported range.

For more information

Please consult our security guide for more information regarding the security model and how to contact us with issues and questions.

Attribution

This vulnerability has been reported by Neophytos Christou from Secure Systems Lab at Brown University.

Basic information

Type
reviewed
Severity
medium
Advisory on GitHub
Open advisory ↗
Repository advisory
Open repository advisory ↗
Source code
Browse source ↗
Published (advisory)
2022-05-24 22:13:23 UTC
Updated
2023-01-27 05:01:57 UTC
GitHub reviewed
2022-05-24 22:13:23 UTC
NVD published
2022-05-20

EPSS Score

Score Percentile
0.08% 23.03%

CVSS Scores

Base score Version Severity Vector
5.5 3.1
CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:N/A:H Click to expand
Attack vector (AV:L)
They already need access on the box, or another person has to do something wrong; it’s not a remote drive-by.
Attack complexity (AC:L)
Once they can reach the bug, pulling it off is straightforward—no weird race conditions or rare setup.
Privileges required (PR:L)
A normal user session is enough; they don’t have to be admin.
User interaction (UI:N)
Nobody has to click “OK” or open a trap file; it can work without a victim helping.
Scope (S:U)
Damage stays in the same “trust bubble” as the broken component—no big spill into unrelated systems.
Confidentiality (C:N)
Doesn’t really leak secrets in a meaningful way.
Integrity (I:N)
Data isn’t meaningfully altered or forged.
Availability (A:H)
Could take the service down hard or make it unusable for people who depend on it.

Identifiers

CWEs

CWE id Name
CWE-20 Improper Input Validation
CWE-476 NULL Pointer Dereference

Affected packages (9)

Vulnerable version ranges and first patched releases as published by GitHub.

Ecosystem Package Vulnerable range First patched Vulnerable functions
pip tensorflow < 2.6.4 2.6.4
pip tensorflow >= 2.7.0, < 2.7.2 2.7.2
pip tensorflow >= 2.8.0, < 2.8.1 2.8.1
pip tensorflow-cpu < 2.6.4 2.6.4
pip tensorflow-cpu >= 2.7.0, < 2.7.2 2.7.2
pip tensorflow-cpu >= 2.8.0, < 2.8.1 2.8.1
pip tensorflow-gpu < 2.6.4 2.6.4
pip tensorflow-gpu >= 2.7.0, < 2.7.2 2.7.2
pip tensorflow-gpu >= 2.8.0, < 2.8.1 2.8.1

References

cvelogic Threat Intelligence