Coder's OIDC authentication allows email with partially matching domain to register

説明

Summary

A vulnerability in Coder's OIDC authentication could allow an attacker to bypass the CODER_OIDC_EMAIL_DOMAIN verification and create an account with an email not in the allowlist. Deployments are only affected if the OIDC provider allows users to create accounts on the provider (such as public providers like google.com).

Details

During OIDC registration, the user's email was improperly validated against the allowed CODER_OIDC_EMAIL_DOMAINs. This could allow a user with a domain that only partially matched an allowed domain to successfully login or register (e.g. [email protected] would match the allowed domain corp.com).

An attacker could register a domain name that exploited this vulnerability and register on a Coder instance with a public OIDC provider.

Impact

Coder instances with OIDC enabled and protected by the CODER_OIDC_EMAIL_DOMAIN configuration.

Coder instances using a private OIDC provider are not affected, as arbitrary users cannot register through a private OIDC provider without first having an account on the provider.

Public OIDC providers (such as google.com without permitted domains set on the OAuth2 App) are impacted.

GitHub authentication and external authentication are not impacted.

Was my deployment impacted?

To check if your deployment was exploited:
- View the audit log on your deployment for unexpected registered users (using the action:register filter)
- Check the users list for unexpected users
- Users created via this exploit will have a domain that ends with one of the allowed domains but doesn’t fully match (e.g. @exploitcorp.com instead of @corp.com)

Patched Versions

This vulnerability is remedied in
- v2.8.4
- v2.7.3
- v2.6.1

All versions prior to these patches are affected by the vulnerability. It is recommended that customers upgrade their deployments as soon as possible if they are utilizing OIDC authentication with the CODER_OIDC_EMAIL_DOMAIN setting.

Thanks

  • https://github.com/arcz
  • https://www.trailofbits.com

References

https://github.com/coder/coder/security/advisories/GHSA-7cc2-r658-7xpf
https://github.com/coder/coder/commit/4439a920e454a82565e445e4376c669e3b89591c
https://nvd.nist.gov/vuln/detail/CVE-2024-27918

基本情報

タイプ
reviewed
深刻度
high
GitHub 上のアドバイザリ
アドバイザリを開く ↗
リポジトリのアドバイザリ
リポジトリのアドバイザリを開く ↗
ソースコード
ソースを見る ↗
公開(アドバイザリ)
2024-03-04 20:45:36 UTC
更新
2024-03-21 18:29:33 UTC
GitHub レビュー済み
2024-03-04 20:45:36 UTC
NVD で公開
2024-03-20

EPSS Score

Score Percentile
0.18% 39.57%

CVSS Scores

Base score Version Severity Vector
8.2 3.1
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:N/A:H クリックして展開
攻撃ベクター (AV:N)
インターネットなど、ルーティングされたネットワーク越しに遠隔から悪用しうる。端末の前にいる必要はない。
攻撃の複雑さ (AC:L)
攻撃者が条件を満たせば、レース条件や珍しい構成に依存せずに再現しやすい。
必要な権限 (PR:N)
事前のログインや昇格は不要で、匿名アクセスのまま踏み台にしうる。
ユーザーの関与 (UI:N)
メールのリンクを開く、マクロを有効にするなど、被害者の協力がなくても成立しうる。
スコープ (S:U)
影響は脆弱コンポーネントと同一のセキュリティ権限・信頼境界の内側に収まる。
機密性への影響 (C:L)
一部のデータや属性が漏えいしうるが、全件一括流出といった規模には至らない。
完全性への影響 (I:N)
改ざん・なりすましによる信頼毀損は軽微か、想定されない。
可用性への影響 (A:H)
長時間のサービス停止、データ損壊による復旧不能に近い状態など、利用者に著しい不便を与えうる。

Identifiers

CWEs

CWE id Name
CWE-20 Improper Input Validation

Credits

  • arcz (reporter)
  • maxammann (coordinator)

Affected packages (4)

Vulnerable version ranges and first patched releases as published by GitHub.

Ecosystem Package Vulnerable range First patched Vulnerable functions
go github.com/coder/coder/v2 >= 2.8.0, < 2.8.4 2.8.4
go github.com/coder/coder/v2 >= 2.7.0, < 2.7.3 2.7.3
go github.com/coder/coder/v2 < 2.6.1 2.6.1
go github.com/coder/coder <= 0.27.3

References

cvelogic Threat Intelligence